AC-7 - Chat list view #26
No reviewers
Labels
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
GamBar/AmberCamp!26
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "AC-7"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Also there are places you use
../../../instad of@but thats not something major so dont worry. Review my comments some are simply questions id like to discuss with you.cant we have this at full width all the time and set the width trough the parent in "styles"
@ -1,10 +1,9 @@export default function Icon({ icon, full, dense, clickable, styles, ...rest }) {Are all icon buttons?
@ -0,0 +1,17 @@import Icon from '../Icon';export default function MobileNavBar({ backButton, backBtnLabel, actionButton, title, moreOptions, actionOptions }) {Is this different from the top bar component we have?
@ -25,0 +51,4 @@clearTimeout(typeTimeout);} else {setTyping(true);}Is this still a bug, how do we react to someone reacting to their own message, how do we react to multible people reacting to one message? Does this require backend work? Should we leave this for when we start making groups?
@ -1,68 +1,75 @@import { useEffect, useState } from 'react';text-[16px]is the same astext-basecan we avoid custom values in general like the
broder-b-[3px]@ -0,0 +1,17 @@import Icon from '../Icon';export default function MobileNavBar({ backButton, backBtnLabel, actionButton, title, moreOptions, actionOptions }) {yes, it is
@ -25,0 +51,4 @@clearTimeout(typeTimeout);} else {setTyping(true);}i think this will require BE work as well, since now it seems like both users can add and remove each others reactions
@ -25,0 +51,4 @@clearTimeout(typeTimeout);} else {setTyping(true);}Yes, seems so, should we leave it for when we make the groups?