Added nesting #2

Merged
TAVnotDove merged 3 commits from schema-object-nesting into main 2025-05-04 14:21:55 -04:00
TAVnotDove commented 2025-04-30 16:29:28 -04:00 (Migrated from github.com)

Added nesting to the schema validations.

Added nesting to the schema validations.
GameBear64 (Migrated from github.com) reviewed 2025-04-30 16:35:44 -04:00
GameBear64 (Migrated from github.com) commented 2025-04-30 16:35:38 -04:00

would you like to try and add a unit test for this? :)
If not ill add a few at a later point

would you like to try and add a unit test for this? :) If not ill add a few at a later point
@ -13,6 +15,8 @@ function validateAndTransform(object) {
const result = additiveTransform(rules, key);
GameBear64 (Migrated from github.com) commented 2025-04-30 16:33:45 -04:00

Is it possible to bind the nested rules as a new this.blueprint, that way we dont intruduce a property that is used only under very specific conditions, id like to shape the implementation around the code instead of the code around the implementation

Is it possible to bind the nested rules as a new this.blueprint, that way we dont intruduce a property that is used only under very specific conditions, id like to shape the implementation around the code instead of the code around the implementation
TAVnotDove (Migrated from github.com) reviewed 2025-05-04 12:38:44 -04:00
@ -13,6 +15,8 @@ function validateAndTransform(object) {
const result = additiveTransform(rules, key);
TAVnotDove (Migrated from github.com) commented 2025-05-04 12:38:43 -04:00

I tinkered with it and couldn't make it work. The point of the addiotional property is to send over the nested rules, but updating this.blueprint doesn't update it's value during recursion. And if it did, it gets returned at the end of the function, so it might need a property to save the initial data, regardless.

I tinkered with it and couldn't make it work. The point of the addiotional property is to send over the nested rules, but updating this.blueprint doesn't update it's value during recursion. And if it did, it gets returned at the end of the function, so it might need a property to save the initial data, regardless.
TAVnotDove (Migrated from github.com) reviewed 2025-05-04 12:39:44 -04:00
TAVnotDove (Migrated from github.com) commented 2025-05-04 12:39:44 -04:00

I have, let me know if they do the job and/or you need more.

I have, let me know if they do the job and/or you need more.
GameBear64 (Migrated from github.com) reviewed 2025-05-04 14:20:28 -04:00
GameBear64 (Migrated from github.com) commented 2025-05-04 14:20:28 -04:00

Thank you! Everything checks out

Thank you! Everything checks out
GameBear64 (Migrated from github.com) reviewed 2025-05-04 14:21:00 -04:00
@ -13,6 +15,8 @@ function validateAndTransform(object) {
const result = additiveTransform(rules, key);
GameBear64 (Migrated from github.com) commented 2025-05-04 14:21:00 -04:00

Thanks for looking into it

Thanks for looking into it
GameBear64 (Migrated from github.com) approved these changes 2025-05-04 14:21:26 -04:00
GameBear64 (Migrated from github.com) left a comment

Looks good

Looks good
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
GamBar/FolderDB!2
No description provided.