GamBar/nail-studio
1
0
Fork 0
Code Issues Pull requests Activity

#NS-21: Admin Panel Layout #10

Merged
catxrin merged 4 commits from #NS-21 into main 2025-01-19 06:13:54 -05:00
Conversation 2 Commits 4 Files changed 19 +176 -36
catxrin commented 2025-01-19 04:39:55 -05:00 (Migrated from github.com)
Copy link
No description provided.
GameBear64 (Migrated from github.com) requested changes 2025-01-19 04:56:57 -05:00
GameBear64 (Migrated from github.com) left a comment
Copy link

Some details need fixing, good job otherwise! 😃

Some details need fixing, good job otherwise! :smiley:
packages/client/src/components/Header.vue
@ -1,38 +1,64 @@
<script setup>
import { useRouter } from 'vue-router';
GameBear64 (Migrated from github.com) commented 2025-01-19 04:48:32 -05:00
Copy link

Copy the enum from the backend

Copy the enum from the backend
GameBear64 (Migrated from github.com) commented 2025-01-19 04:49:19 -05:00
Copy link

you mean clear user data?

you mean clear user data?
packages/client/src/components/Layout/DesktopNavigation.vue
@ -14,6 +15,10 @@ const props = defineProps(['navigations', 'options']);
const open = ref(false);
GameBear64 (Migrated from github.com) commented 2025-01-19 04:50:15 -05:00
Copy link

can we use a computed value here?

can we use a computed value here?
GameBear64 (Migrated from github.com) commented 2025-01-19 04:50:28 -05:00
Copy link

Horrible formatting, run litner

Horrible formatting, run litner
GameBear64 (Migrated from github.com) commented 2025-01-19 04:50:53 -05:00
Copy link

return? can we instead use an implicit return?

return? can we instead use an implicit return?
packages/client/src/components/Layout/MobileNavigation.vue
@ -44,3 +47,4 @@
<p :onclick="() => router.push(navigation.location)">
{{ navigation.name }}
</p>
</div>
GameBear64 (Migrated from github.com) commented 2025-01-19 04:53:06 -05:00
Copy link

does v-show or v-if not work here?

does v-show or v-if not work here?
packages/client/src/pages/AdminPanel.vue
@ -0,0 +1,37 @@
<script setup>
GameBear64 (Migrated from github.com) commented 2025-01-19 04:53:34 -05:00
Copy link

This import style should be used only in js files, this is a vue component

This import style should be used only in js files, this is a vue component
GameBear64 (Migrated from github.com) commented 2025-01-19 04:53:46 -05:00
Copy link

@components/Icon

@components/Icon
packages/client/src/router.js
GameBear64 (Migrated from github.com) commented 2025-01-19 04:55:27 -05:00
Copy link

unused variable from

unused variable from
GameBear64 (Migrated from github.com) approved these changes 2025-01-19 06:13:45 -05:00
GameBear64 (Migrated from github.com) left a comment
Copy link

Good job 😸

Good job :smile_cat:
Sign in to join this conversation.
Reviewers
No reviewers
GameBear64
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
GamBar/nail-studio!10
No description provided.