GamBar/nail-studio
1
0
Fork 0
Code Issues Pull requests Activity

#ns 3 #2

Merged
catxrin merged 13 commits from #NS-3 into main 2024-12-05 05:50:13 -05:00
Conversation 2 Commits 13 Files changed 21 +487 -50
catxrin commented 2024-12-04 16:17:39 -05:00 (Migrated from github.com)
Copy link

Made the login and register, set up form and form inputs

Made the login and register, set up form and form inputs
GameBear64 (Migrated from github.com) requested changes 2024-12-04 16:32:01 -05:00
GameBear64 (Migrated from github.com) left a comment
Copy link

Great work, I have requested small fixes, do them and we will be good for merge!

Great work, I have requested small fixes, do them and we will be good for merge!
packages/client/src/components/Form/PasswordInput.vue
@ -0,0 +1,46 @@
<script setup>
GameBear64 (Migrated from github.com) commented 2024-12-04 16:23:39 -05:00
Copy link

Woudnt this break the id? we cant have spaces in IDs line:30

Woudnt this break the id? we cant have spaces in IDs line:30
GameBear64 (Migrated from github.com) commented 2024-12-04 16:24:03 -05:00
Copy link

:for="$attrs.name"

:for="$attrs.name"
packages/client/src/components/Form/SelectInput.vue
@ -0,0 +1,28 @@
<script setup>
GameBear64 (Migrated from github.com) commented 2024-12-04 16:24:46 -05:00
Copy link

same as PasswordInput, we may be breaking the ids and names this way

same as PasswordInput, we may be breaking the ids and names this way
GameBear64 (Migrated from github.com) commented 2024-12-04 16:25:03 -05:00
Copy link

remove this as name is set by binding attrs on line 16

remove this as name is set by binding attrs on line 16
packages/client/src/components/Form/StrengthInput.vue
@ -0,0 +1,55 @@
<script setup>
GameBear64 (Migrated from github.com) commented 2024-12-04 16:25:56 -05:00
Copy link

Same thing here, also on line 29 name is already handled by attrs

Same thing here, also on line 29 name is already handled by attrs
GameBear64 (Migrated from github.com) commented 2024-12-04 16:28:52 -05:00
Copy link

lets instead calculate the max from the rules const, maybe Object.keys().length

lets instead calculate the max from the rules const, maybe Object.keys().length
packages/client/src/components/Form/TextArea.vue
@ -0,0 +1,19 @@
<script setup>
GameBear64 (Migrated from github.com) commented 2024-12-04 16:26:10 -05:00
Copy link

here too

here too
packages/server/db/users/22605685.json
GameBear64 (Migrated from github.com) commented 2024-12-04 16:30:46 -05:00
Copy link

In this project we also commit the database, lets keep it clean and have only relevant entries, keep only one test user

Note to self: dont save the confirm password

In this project we also commit the database, lets keep it clean and have only relevant entries, keep only one test user Note to self: dont save the confirm password
GameBear64 (Migrated from github.com) approved these changes 2024-12-05 05:48:35 -05:00
GameBear64 (Migrated from github.com) left a comment
Copy link

Good job!

Good job!
Sign in to join this conversation.
Reviewers
No reviewers
GameBear64
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
GamBar/nail-studio!2
No description provided.