GamBar/nail-studio
1
0
Fork 0
Code Issues Pull requests Activity

#ns 12 #5

Merged
catxrin merged 13 commits from #NS-12 into main 2024-12-12 07:39:23 -05:00
Conversation 5 Commits 13 Files changed 16 +256 -26
catxrin commented 2024-12-11 03:42:55 -05:00 (Migrated from github.com)
Copy link
No description provided.
GameBear64 (Migrated from github.com) requested changes 2024-12-11 04:40:50 -05:00
packages/client/src/components/Layout/MobileNavigation.vue
@ -0,0 +1,66 @@
<script setup>
GameBear64 (Migrated from github.com) commented 2024-12-11 04:37:41 -05:00
Copy link

Can we add the functionality to close the mobile navigation when you click outside of it - in the blured background

Can we add the functionality to close the mobile navigation when you click outside of it - in the blured background
GameBear64 (Migrated from github.com) requested changes 2024-12-11 05:10:11 -05:00
packages/client/src/components/Layout/DesktopNavigation.vue
@ -0,0 +1,58 @@
<script setup>
GameBear64 (Migrated from github.com) commented 2024-12-11 05:10:08 -05:00
Copy link

Rename this file and replace this C with an icon

Rename this file and replace this C with an icon
GameBear64 (Migrated from github.com) requested changes 2024-12-11 16:31:32 -05:00
packages/client/tailwind.config.js
@ -19,6 +19,15 @@ export default {
// because we override base with a color
md: ['1rem', '1.5rem'],
GameBear64 (Migrated from github.com) commented 2024-12-11 16:31:00 -05:00
Copy link

No need to overwrite the defaults, its fine to comment the values for referance purposes, I propose we have only add to these

     screens: {
       minimum: '320px',
       xs: '430px',
       // sm 640px
       // md 768px
       // lg 1024px
       // xl 1280px
       // 2xl 1536px
     },
No need to overwrite the defaults, its fine to comment the values for referance purposes, I propose we have only add to these ```suggestion screens: { minimum: '320px', xs: '430px', // sm 640px // md 768px // lg 1024px // xl 1280px // 2xl 1536px }, ```
GameBear64 (Migrated from github.com) reviewed 2024-12-11 16:32:13 -05:00
packages/client/src/router.js
GameBear64 (Migrated from github.com) commented 2024-12-11 16:32:12 -05:00
Copy link

try catch is ugly, can we use .then? :]

try catch is ugly, can we use .then? :]
GameBear64 (Migrated from github.com) approved these changes 2024-12-12 07:38:40 -05:00
Sign in to join this conversation.
Reviewers
No reviewers
GameBear64
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
GamBar/nail-studio!5
No description provided.