GamBar/nail-studio
1
0
Fork 0
Code Issues Pull requests Activity

#NS 8 #8

Merged
catxrin merged 9 commits from #NS-8 into main 2025-01-15 04:44:57 -05:00
Conversation 2 Commits 9 Files changed 17 +185 -20
catxrin commented 2025-01-14 05:38:21 -05:00 (Migrated from github.com)
Copy link
No description provided.
GameBear64 (Migrated from github.com) requested changes 2025-01-14 07:16:51 -05:00
GameBear64 (Migrated from github.com) left a comment
Copy link

Great work, lets do some code cleanup

Great work, lets do some code cleanup
packages/client/main.css
@ -86,3 +90,14 @@
--txtSecondary: theme('colors.neutral.300');
GameBear64 (Migrated from github.com) commented 2025-01-14 07:06:19 -05:00
Copy link

Do we need these comments?

Do we need these comments?
packages/client/src/App.vue
@ -9,0 +11,4 @@
import 'swiper/css/free-mode';
import 'swiper/css/pagination';
import 'swiper/css/navigation';
GameBear64 (Migrated from github.com) commented 2025-01-14 07:06:41 -05:00
Copy link

added space?

added space?
packages/client/src/components/Banner.vue
GameBear64 (Migrated from github.com) commented 2025-01-14 07:15:13 -05:00
Copy link

does this get rid of the padding on bigger screens? if it does, keep the padding please with sm:p-2 or md:p-2

does this get rid of the padding on bigger screens? if it does, keep the padding please with sm:p-2 or md:p-2
packages/client/src/components/Icon.vue
@ -1,5 +1,5 @@
<script setup>
GameBear64 (Migrated from github.com) commented 2025-01-14 07:07:43 -05:00
Copy link

nit pick, can we format this better 😅
maybe run the linter command, it should pretty-up the code

nit pick, can we format this better 😅 maybe run the linter command, it should pretty-up the code
packages/client/src/components/Layout/DesktopNavigation.vue
@ -27,24 +27,29 @@ const arrow = computed(() => (open.value ? 'keyboard_arrow_up' : 'keyboard_arrow
:key="navigation.name"
GameBear64 (Migrated from github.com) commented 2025-01-14 07:14:30 -05:00
Copy link

can you try if just "clickable" works? now that you added types to the icon it should work auto-magically ;)

can you try if just "clickable" works? now that you added types to the icon it should work auto-magically ;)
packages/client/src/components/Swiper.vue
@ -0,0 +1,37 @@
<script setup>
GameBear64 (Migrated from github.com) commented 2025-01-14 07:08:33 -05:00
Copy link

Rename component to "artists" or something, "Swiper" suggests this is just a general swiper component

Rename component to "artists" or something, "Swiper" suggests this is just a general swiper component
GameBear64 (Migrated from github.com) commented 2025-01-14 07:12:31 -05:00
Copy link

You can use tailwind's line clamp to make a responsive truncation, read more about it here

https://tailwindcss.com/docs/line-clamp

You can use tailwind's line clamp to make a responsive truncation, read more about it here https://tailwindcss.com/docs/line-clamp
GameBear64 (Migrated from github.com) commented 2025-01-14 07:15:41 -05:00
Copy link

can we import these on an app level since swiper will be used in many places troughout the app

can we import these on an app level since swiper will be used in many places troughout the app
GameBear64 (Migrated from github.com) commented 2025-01-14 07:16:15 -05:00
Copy link

can we have an Artist Card component? we might want to reuse it later for out booking flow

can we have an Artist Card component? we might want to reuse it later for out booking flow
GameBear64 (Migrated from github.com) approved these changes 2025-01-15 04:44:41 -05:00
GameBear64 (Migrated from github.com) left a comment
Copy link

Much better, good job

Much better, good job
Sign in to join this conversation.
Reviewers
No reviewers
GameBear64
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
GamBar/nail-studio!8
No description provided.